Hi Arvid, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 1c23f9e627a7b412978b4e852793c5e3c3efc555] url: https://github.com/intel-lab-lkp/linux/commits/Arvid-Norlander/platform-x86-Battery-charge-mode-in-toshiba_acpi/20220829-033110 base: 1c23f9e627a7b412978b4e852793c5e3c3efc555 config: x86_64-randconfig-a002-20220829 (https://download.01.org/0day-ci/archive/20220829/202208290628.Er7oPvnk-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/a85fa4a6b19ae082f6018a07da93db965fb5ba11 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Arvid-Norlander/platform-x86-Battery-charge-mode-in-toshiba_acpi/20220829-033110 git checkout a85fa4a6b19ae082f6018a07da93db965fb5ba11 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/platform/x86/toshiba_acpi.c: In function 'charge_control_end_threshold_show': >> drivers/platform/x86/toshiba_acpi.c:2992:13: warning: variable 'status' set but not used [-Wunused-but-set-variable] 2992 | int status; | ^~~~~~ vim +/status +2992 drivers/platform/x86/toshiba_acpi.c 2984 2985 2986 /* ACPI battery hooking */ 2987 static ssize_t charge_control_end_threshold_show(struct device *device, 2988 struct device_attribute *attr, 2989 char *buf) 2990 { 2991 int state; > 2992 int status; 2993 2994 if (toshiba_acpi == NULL) { 2995 pr_err("Toshiba ACPI object invalid\n"); 2996 return -ENODEV; 2997 } 2998 2999 status = toshiba_battery_charge_mode_get(toshiba_acpi, &state); 3000 if (state == 1) 3001 return sprintf(buf, "80\n"); 3002 else 3003 return sprintf(buf, "100\n"); 3004 } 3005 -- 0-DAY CI Kernel Test Service https://01.org/lkp
