On Sun, Jun 12, 2022 at 3:54 PM <stefan.seyfried@xxxxxxxxxxxxxx> wrote: > > From: Stefan Seyfried <seife+kernel@xxxxxxxxxxxxxx> > > commit ed83c9171829 broke the hotkeys on my Toughbook CF-51. The commit > I'm questioning the general validity of that commit, but as I only > have a single machine to test, add a module parameter to allow making > it work at runtime. Thanks for the report and the fix, my comments below. > +static bool hotkey_input; > +module_param(hotkey_input, bool, 0644); > +MODULE_PARM_DESC(hotkey_input, "Send all hotkeys to the input subsystem"); We usually add module options in very bad cases where it's very useful for debugging or when some devices require the opposite settings while can't be distinguished automatically. Here I do not see either of such cases. Hence, I would prefer to see a DMI based quirk as it's done a lot in the PDx86 drivers. Can you do that? -- With Best Regards, Andy Shevchenko
