I'm resending it due to reported spam. I forgot to turn off HTML formatting. My bad. Thanks for the patches. > From: Stefan Seyfried <seife+kernel@xxxxxxxxxxxxxx> > > commit ed83c9171829 broke the hotkeys on my Toughbook CF-51. > I'm questioning the general validity of that commit, but as I only > have a single machine to test, add a module parameter to allow making > it work at runtime. I can confirm that as soon as the hotkey_input option is enabled (at least on my aged CF-W5) it reports the ACPI event twice. Unfortunately it's the only machine I have for testing. Unless we have a bigger sample base, making it a module_param is a safe choice. Otherwise the patches look good to me. Reviewed-by: Kenneth Chan <kenneth.t.chan@xxxxxxxxx> -- Kenneth
