Re: [PATCH v2 1/2] Resolve WMI query failures on some devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 9, 2022 at 3:45 PM Jorge Lopez <jorgealtxwork@xxxxxxxxx> wrote:
> On Thu, Jun 9, 2022 at 5:50 AM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Wed, Jun 8, 2022 at 11:04 PM Jorge Lopez <jorgealtxwork@xxxxxxxxx> wrote:

...

> > > Regarding the statement  ...
> > >
> > >       Please, be careful and read all comments you have been given and react
> > >       to them either by explaining why it's not worth to address or with an
> > >       addressed changes.
> > >
> > > All other comments have been addressed in the commit notes and via
> > > email.
> >
> > I have noticed that by reading the next patch. As I mentioned there,
> > it should be squashed to the first one, I never expected to see two
> > patches on this topic.
>
> This is my first year working with kernel upstream teams and reviewers
> hence I am a newcomer.  For this reason, I was being cautious and
> separated the changes instead of squashing them.  Please excuse my
> inexperience in the matter.

No problem, everything is good enough, just a couple of technical
improvements on the process. You are doing right in the general case
and it's rare, in contrast to awful github, that kernel maintainers
ask for a squash.

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux