Hi Andy,
Failure to run your tool and include all the appropriate parties in
the review was an oversight on my part. I will make sure it is done
in the following patches.
Regarding the statement ...
Please, be careful and read all comments you have been given and react
to them either by explaining why it's not worth to address or with an
addressed changes.
All other comments have been addressed in the commit notes and via
email. The comments addressed were
- As a quick fix it's good, but have you had a chance to understand why
this failure happened in the first place?
- Can you check my theory that is expressed in the code below?
- Leverage ge2maintainer tool to include all appropriate parties.
(See earlier comment)
Did I address all the comments? If not, please accept my apologies
and kindly point to the question(s) I need to address.
Regards,
Jorge
On Wed, Jun 8, 2022 at 1:45 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Wed, Jun 8, 2022 at 7:20 PM Jorge Lopez <jorgealtxwork@xxxxxxxxx> wrote:
> >
> > WMI queries fail on some devices where the ACPI method HWMC
> > unconditionally attempts to create Fields beyond the buffer
> > if the buffer is too small, this breaks essential features
> > such as power profiles:
> >
> > CreateByteField (Arg1, 0x10, D008)
> > CreateByteField (Arg1, 0x11, D009)
> > CreateByteField (Arg1, 0x12, D010)
> > CreateDWordField (Arg1, 0x10, D032)
> > CreateField (Arg1, 0x80, 0x0400, D128)
> >
> > In cases where args->data had zero length, ACPI BIOS Error
> > (bug): AE_AML_BUFFER_LIMIT, Field [D008] at bit
> > offset/length 128/8 exceeds size of target Buffer (128 bits)
> > (20211217/dsopcode-198) was obtained.
> >
> > ACPI BIOS Error (bug): AE_AML_BUFFER_LIMIT, Field [D009] at bit
> > offset/length 136/8 exceeds size of target Buffer (136bits)
> > (20211217/dsopcode-198)
> >
> > The original code created a buffer size of 128 bytes regardless if
> > the WMI call required a smaller buffer or not. This particular
> > behavior occurs in older BIOS and reproduced in OMEN laptops. Newer
> > BIOS handles buffer sizes properly and meets the latest specification
> > requirements. This is the reason why testing with a dynamically
> > allocated buffer did not uncover any failures with the test systems at
> > hand.
> >
> > This patch was tested on several OMEN, Elite, and Zbooks. It was
> > confirmed the patch resolves HPWMI_FAN GET/SET calls in an OMEN
> > Laptop 15-ek0xxx. No problems were reported when testing on several Elite
> > and Zbooks notebooks.
>
> ...
>
> > struct bios_args *args = NULL;
> > int mid, actual_outsize, ret;
> > size_t bios_args_size;
> > + int actual_insize;
>
> Same comment as per v1.
>
> Please, be careful and read all comments you have been given and react
> to them either by explaining why it's not worth to address or with an
> addressed changes.
>
> --
> With Best Regards,
> Andy Shevchenko
