Hi, On 2/6/22 20:50, Andy Shevchenko wrote: > On Sun, Feb 6, 2022 at 9:22 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> On 2/5/22 21:40, Andy Shevchenko wrote: >>> On Sat, Feb 5, 2022 at 9:14 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > ... > >>> USB ID change is not described here. >> >> There is no USB-ID change, > > ... > >> Since adding lid_switch support involves adding a second pdev, >> the contents of the generic int3496_pdevs now gets duplicated into >> the new pdevs array which adds the lid gpio_keys pdev: > > I see now. Perhaps a comment about it in the commit message? Ok, I've added a comment to the commit msg while merging this series into my review-hans branch. Regards, Hans