On Sun, Feb 6, 2022 at 9:22 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 2/5/22 21:40, Andy Shevchenko wrote: > > On Sat, Feb 5, 2022 at 9:14 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: ... > > USB ID change is not described here. > > There is no USB-ID change, ... > Since adding lid_switch support involves adding a second pdev, > the contents of the generic int3496_pdevs now gets duplicated into > the new pdevs array which adds the lid gpio_keys pdev: I see now. Perhaps a comment about it in the commit message? ... > >> + /* .gpio gets filled in by asus_me176c_tf103c_init() */ > > > > I'm wondering if we can switch gpio_keys*.c drivers to accept GPIO > > descriptor directly. > The current gpio_keys_platform_data struct which expects an > old style gpio integer number is used in a ton of places: Yes. > So changing this is going to be a lot of work, gpio_keys does already operate with descriptors inside. It would be easy to add a new member and extend a check, but... > it certainly is > out of scope for this patch-set. ...yes, it's not directly related to this series. -- With Best Regards, Andy Shevchenko
