Hi, On 1/4/22 15:08, Andy Shevchenko wrote: > On Sat, Dec 25, 2021 at 04:41:58PM +0200, Andy Shevchenko wrote: >> On Sat, Dec 25, 2021 at 2:00 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >>> >>> The gpio-tps68470 driver binds to a tps68470-gpio platform-device which >>> itself gets instantiated by a special MFD driver from >>> drivers/platform/x86/intel/int3472/tps68470.c >>> >>> This MFD driver itself can be build as a module, so it makes no sense to >> >> built >> >>> force the gpio-tps68470 driver to always be builtin. >> >> built-in >> >> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> >> (see one minor comment below) > > I don't see the next version, in any case it's too far from the beginning of > the v5.16 cycle and I gave my tags so Bart may (or may not :-) apply them. If > it's okay to be v5.18 material, I'll take a new version sent after v5.17-rc1. It is fine for this to go into v5.18, thank you for your review. I'll send a new version addressing your comments. Regards, Hans
