Hi, On 9/13/21 2:15 PM, Barnabás Pőcze wrote: > Hi > > > 2021. szeptember 13., hétfő 13:53 keltezéssel, Hans de Goede írta: >> In "platform/x86: wmi: introduce helper to generate method names" >> you added a get_acpi_method_name() helper for generating WMI >> method-names and you are using that everywhere else. >> >> IMHO it would be better to also use that here. Is there any >> specific reason why you are not using this here ? > > Yes, indeed, but `get_acpi_method_name()` uses the `object_id` of the GUID block, > this one uses the `notify_id`. And it seemed problematic to find a simple > way to reconcile the differences, so I haven't really given it much thought. > I'm open to suggestions. Ah I see, TBH I liked your original patch just adding sizeof() better then the new one. Or maybe replace the 2 "5"-s used in the snprintf version with WMI_ACPI_METHOD_NAME_SIZE ? Regards, Hans
