Re: [PATCH v1] platform/x86: wmi: initialize method name directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi


2021. szeptember 13., hétfő 13:53 keltezéssel, Hans de Goede írta:
> In "platform/x86: wmi: introduce helper to generate method names"
> you added a get_acpi_method_name() helper for generating WMI
> method-names and you are using that everywhere else.
>
> IMHO it would be better to also use that here. Is there any
> specific reason why you are not using this here ?

Yes, indeed, but `get_acpi_method_name()` uses the `object_id` of the GUID block,
this one uses the `notify_id`. And it seemed problematic to find a simple
way to reconcile the differences, so I haven't really given it much thought.
I'm open to suggestions.


Regards,
Barnabás Pőcze




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux