On Mi, 2021-08-25T11:47-0500, Daniel Dadap wrote: >> +static const struct wmi_device_id wmaa_backlight_wmi_id_table[] = { >> + { .guid_string = WMAA_WMI_GUID }, >> + { }, > > > +MODULE_ALIAS("wmi:"WMAA_WMI_GUID); > > Can you move this closer to GUID? But I'm not sure what is the > > preferred style. Hans? > > > I'll do whatever is most stylistically preferred. > This could also be expressed as, which is presumably the nicer way: MODULE_DEVICE_TABLE(wmi, wmaa_backlight_wmi_id_table); Thomas