Hi, On 8/19/21 3:31 PM, Hans de Goede wrote: > Hi, > > On 8/19/21 2:14 PM, Andy Shevchenko wrote: >> On Thu, Aug 19, 2021 at 3:03 PM Andy Shevchenko >> <andy.shevchenko@xxxxxxxxx> wrote: >>> On Thu, Aug 19, 2021 at 1:48 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >>> >>> >>>> Thank you for your patch-series, I've applied the series to my >>>> review-hans branch: >>>> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans >>>> >>>> With the changes mentioned in replies to individual patches. >>> >>> Can we postpone this a bit, please? >>> >>> I have a few comments here and there. I'll send asap. >> >> Hmm... It seems it will take less time if I simply take what you have >> in your repo and produce a v4. >> Would it work? > > That is fine by me, I might be better to just do a small follow-up patch > though, given that you seem to only have a few small remarks. > > But if you prefer to do a v4 that is fine too. I was planning on > keeping this in review-hans for a while anyways. > > I did notice the couple of stray changes which you pointed out but > they get corrected by other commits (or are removal of extra whitespace > left-over from other commits), so I decided that they were harmless > since the end-result Makefile / Kconfig files were good. p.s. Note that drivers/platform/x86/intel_ips.h is deliberately not moved (for now) since it is also used by the i915 driver. My plan is to merge a follow-up patch moving that through drm-intel-next once 5.15-rc1 is out. Regards, Hans