Hi, On 8/19/21 5:29 AM, Kate Hsuan wrote: > v3 has some improvement and listed below. > kconfig typo correction. > commit message improvement. > Fix two kernel test robot fail issues. > > Kate Hsuan (20): > platform/x86: intel_bxtwc_tmu: Move to intel sub-directory > platform/x86: intel_chtdc_ti_pwrbtn: Move to intel sub-directory > platform/x86: intel_mrfld_pwrbtn: Move to intel sub-directory > platform/x86: intel_punit_ipc: Move to intel sub-directory > platform/x86: intel_pmc_core: Move to intel sub-directory > platform/x86: intel_scu: Move to intel sub-directory > platform/x86: intel_telemetry: Move to intel sub-directory > platform/x86: intel_ips: Move to intel sub-directory > platform/x86: intel-rst: Move to intel sub-directory > platform/x86: intel-smartconnect: Move to intel sub-directory > platform/x86: intel_turbo_max_3: Move to intel sub-directory > platform/x86: intel-uncore-frequency: Move to intel sub-directory > platform/x86: intel_speed_select_if: Move to intel sub-directory > platform/x86: intel_atomisp2_led: Move to intel sub-directory > platform/x86: intel-hid: Move to intel sub-directory > platform/x86: intel_int0002_vgpio: Move to intel sub-directory > platform/x86: intel_oaktrail: Move to intel sub-directory > platform/x86: intel-vbtn: Move to intel sub-directory > platform/x86: intel-wmi-sbl-fw-updat: Move to intel sub-directory > platform/x86: intel-wmi-thunderbolt: Move to intel sub-directory Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans With the changes mentioned in replies to individual patches. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > > drivers/platform/x86/Kconfig | 287 ------------------ > drivers/platform/x86/Makefile | 34 +-- > drivers/platform/x86/intel/Kconfig | 160 ++++++++++ > drivers/platform/x86/intel/Makefile | 44 +++ > drivers/platform/x86/intel/atomisp2/Kconfig | 38 +++ > drivers/platform/x86/intel/atomisp2/Makefile | 9 + > .../atomisp2/led.c} | 0 > .../atomisp2/pm.c} | 0 > .../{intel_bxtwc_tmu.c => intel/bxtwc_tmu.c} | 0 > .../chtdc_ti_pwrbtn.c} | 0 > .../platform/x86/{intel-hid.c => intel/hid.c} | 2 +- > .../int0002_vgpio.c} | 0 > .../platform/x86/{intel_ips.c => intel/ips.c} | 2 +- > .../mrfld_pwrbtn.c} | 0 > .../{intel_oaktrail.c => intel/oaktrail.c} | 0 > drivers/platform/x86/intel/pmc/Kconfig | 26 ++ > drivers/platform/x86/intel/pmc/Makefile | 9 + > .../x86/{ => intel/pmc}/intel_pmc_core.h | 0 > .../pmc/pmc_core.c} | 0 > .../pmc/pmc_core_pltdrv.c} | 0 > .../{intel_punit_ipc.c => intel/punit_ipc.c} | 0 > .../platform/x86/{intel-rst.c => intel/rst.c} | 0 > drivers/platform/x86/intel/scu/Kconfig | 52 ++++ > drivers/platform/x86/intel/scu/Makefile | 13 + > .../x86/{intel_scu_ipc.c => intel/scu/ipc.c} | 0 > .../scu/ipcutil.c} | 0 > .../scu/pcidrv.c} | 0 > .../scu/pltdrv.c} | 0 > .../x86/{intel_scu_wdt.c => intel/scu/wdt.c} | 0 > .../smartconnect.c} | 0 > .../speed_select_if}/Kconfig | 0 > .../speed_select_if}/Makefile | 0 > .../speed_select_if}/isst_if_common.c | 0 > .../speed_select_if}/isst_if_common.h | 0 > .../speed_select_if}/isst_if_mbox_msr.c | 0 > .../speed_select_if}/isst_if_mbox_pci.c | 0 > .../speed_select_if}/isst_if_mmio.c | 0 > drivers/platform/x86/intel/telemetry/Kconfig | 16 + > drivers/platform/x86/intel/telemetry/Makefile | 11 + > .../telemetry/core.c} | 0 > .../telemetry/debugfs.c} | 0 > .../telemetry/pltdrv.c} | 0 > .../turbo_max_3.c} | 0 > .../uncore-frequency.c} | 0 > .../x86/{intel-vbtn.c => intel/vbtn.c} | 2 +- > drivers/platform/x86/intel/wmi/Kconfig | 26 ++ > drivers/platform/x86/intel/wmi/Makefile | 9 + > .../wmi/sbl-fw-update.c} | 0 > .../wmi/thunderbolt.c} | 0 > 49 files changed, 419 insertions(+), 321 deletions(-) > create mode 100644 drivers/platform/x86/intel/atomisp2/Kconfig > create mode 100644 drivers/platform/x86/intel/atomisp2/Makefile > rename drivers/platform/x86/{intel_atomisp2_led.c => intel/atomisp2/led.c} (100%) > rename drivers/platform/x86/{intel_atomisp2_pm.c => intel/atomisp2/pm.c} (100%) > rename drivers/platform/x86/{intel_bxtwc_tmu.c => intel/bxtwc_tmu.c} (100%) > rename drivers/platform/x86/{intel_chtdc_ti_pwrbtn.c => intel/chtdc_ti_pwrbtn.c} (100%) > rename drivers/platform/x86/{intel-hid.c => intel/hid.c} (99%) > rename drivers/platform/x86/{intel_int0002_vgpio.c => intel/int0002_vgpio.c} (100%) > rename drivers/platform/x86/{intel_ips.c => intel/ips.c} (99%) > rename drivers/platform/x86/{intel_mrfld_pwrbtn.c => intel/mrfld_pwrbtn.c} (100%) > rename drivers/platform/x86/{intel_oaktrail.c => intel/oaktrail.c} (100%) > create mode 100644 drivers/platform/x86/intel/pmc/Kconfig > create mode 100644 drivers/platform/x86/intel/pmc/Makefile > rename drivers/platform/x86/{ => intel/pmc}/intel_pmc_core.h (100%) > rename drivers/platform/x86/{intel_pmc_core.c => intel/pmc/pmc_core.c} (100%) > rename drivers/platform/x86/{intel_pmc_core_pltdrv.c => intel/pmc/pmc_core_pltdrv.c} (100%) > rename drivers/platform/x86/{intel_punit_ipc.c => intel/punit_ipc.c} (100%) > rename drivers/platform/x86/{intel-rst.c => intel/rst.c} (100%) > create mode 100644 drivers/platform/x86/intel/scu/Kconfig > create mode 100644 drivers/platform/x86/intel/scu/Makefile > rename drivers/platform/x86/{intel_scu_ipc.c => intel/scu/ipc.c} (100%) > rename drivers/platform/x86/{intel_scu_ipcutil.c => intel/scu/ipcutil.c} (100%) > rename drivers/platform/x86/{intel_scu_pcidrv.c => intel/scu/pcidrv.c} (100%) > rename drivers/platform/x86/{intel_scu_pltdrv.c => intel/scu/pltdrv.c} (100%) > rename drivers/platform/x86/{intel_scu_wdt.c => intel/scu/wdt.c} (100%) > rename drivers/platform/x86/{intel-smartconnect.c => intel/smartconnect.c} (100%) > rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/Kconfig (100%) > rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/Makefile (100%) > rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/isst_if_common.c (100%) > rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/isst_if_common.h (100%) > rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/isst_if_mbox_msr.c (100%) > rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/isst_if_mbox_pci.c (100%) > rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/isst_if_mmio.c (100%) > create mode 100644 drivers/platform/x86/intel/telemetry/Kconfig > create mode 100644 drivers/platform/x86/intel/telemetry/Makefile > rename drivers/platform/x86/{intel_telemetry_core.c => intel/telemetry/core.c} (100%) > rename drivers/platform/x86/{intel_telemetry_debugfs.c => intel/telemetry/debugfs.c} (100%) > rename drivers/platform/x86/{intel_telemetry_pltdrv.c => intel/telemetry/pltdrv.c} (100%) > rename drivers/platform/x86/{intel_turbo_max_3.c => intel/turbo_max_3.c} (100%) > rename drivers/platform/x86/{intel-uncore-frequency.c => intel/uncore-frequency.c} (100%) > rename drivers/platform/x86/{intel-vbtn.c => intel/vbtn.c} (99%) > create mode 100644 drivers/platform/x86/intel/wmi/Kconfig > create mode 100644 drivers/platform/x86/intel/wmi/Makefile > rename drivers/platform/x86/{intel-wmi-sbl-fw-update.c => intel/wmi/sbl-fw-update.c} (100%) > rename drivers/platform/x86/{intel-wmi-thunderbolt.c => intel/wmi/thunderbolt.c} (100%) >