On Fri, 06 Aug 2021, Chris wrote: > On Fri, Aug 6, 2021 at 8:59 AM Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: > > > > On Fri, Aug 6, 2021 at 4:55 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > > On 8/6/21 9:52 AM, Andy Shevchenko wrote: > > > > On Fri, Aug 6, 2021 at 5:47 AM Chris Blake <chrisrblake93@xxxxxxxxx> wrote: > > > > ... > > > > > >> +#include <linux/gpio/machine.h> > > > > > > > > Does this provide a GPIO controller driver? I don't think so. > > > > > > Actually GPIO controller drivers use <linux/gpio/driver.h> > > > <linux/gpio/machine.h> for board files / glue code which > > > e.g. needs to add lookup-tables, which this code does, > > > so including this header is correct. > > > > Ah, indeed. I stand corrected. > > > > Hello, > > Thank you both for the feedback, i'll work on getting the fixes > implemented. The only one I have issues with is finding the git hash > for the dependency commit in mfd, since I don't see it merged up yet > to the maintainers staging branch at > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/. Check again. :) > @Lee, sorry to tag you in but any chance you have the git hash for the > PR I did earlier that you accepted for 5.15? It was named: mfd: > lpc_ich: Enable GPIO driver for DH89xxCC. ef0eea5b151ae ("mfd: lpc_ich: Enable GPIO driver for DH89xxCC") -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
