Hi, On 8/6/21 5:49 PM, Andy Shevchenko wrote: > The 'objs' is for user space tools, for the kernel modules > we should use 'y'. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/intel/int3472/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel/int3472/Makefile b/drivers/platform/x86/intel/int3472/Makefile > index 48bd97f0a04e..2362e04db18d 100644 > --- a/drivers/platform/x86/intel/int3472/Makefile > +++ b/drivers/platform/x86/intel/int3472/Makefile > @@ -1,5 +1,5 @@ > obj-$(CONFIG_INTEL_SKL_INT3472) += intel_skl_int3472.o > -intel_skl_int3472-objs := intel_skl_int3472_common.o \ > +intel_skl_int3472-y := intel_skl_int3472_common.o \ > intel_skl_int3472_discrete.o \ > intel_skl_int3472_tps68470.o \ > intel_skl_int3472_clk_and_regulator.o >