Hi, On 6/16/21 6:16 PM, leo60228 wrote: >> We only accept contributions under real-names, so you need to >> use your real first + lastname here. > > I'm thinking about what to do here. I generally don't use my real name online. Ok, I'm afraid that using your real-name is a hard requirements for kernel contributions. >> Also the GUID you are using: >> >> #define ACER_LED_METHOD_GUID "7A4DDFE7-5B5D-40B4-8595-4408E0CC7F56" >> >> Is the same one as used by another recent patch for adding >> keyboard LED zones support for Acer laptops: >> >> https://lore.kernel.org/platform-driver-x86/CAMW3L+24ZGowtpURUbjoCoA+eZMF0wDae1izxS+HM2uz1L9Rig@xxxxxxxxxxxxxx/ >> >> I've added Jafar to the Cc here. >> >> So it looks like we have 2 people working on the same driver, >> please coordinate between the 2 of you to submit a single driver. > > I looked at that driver and our hardware seems very different (mine doesn't have any support for the special effects, for example). Hmm, but you do have both 4 RGB LED zones which are addressable per zone, are you saying that the code for supporting that basic functionality is also different ? Note Jafar's driver did not use the LED API sofar, it was simply forwarding an array of bytes from userspace to a WMI call. > I agree that we should likely collaborate, even if that's just to ensure this driver works on more hardware. Ack. >> All these lines can be replaced by a single: >> >> module_wmi_driver(acer_led_driver); >> >> statement. > I already submitted a V2 fixing this among other things, sorry abou >> module_wmi_driver(acer_led_driver); >> >> statement. > > I already submitted a V2 fixing this among other things, sorry about that. Do you know if there's anything I could've done to make it more discoverable? My bad, I did see the v2, but I accidentally replied to the v1. Regards, Hans
