From: Tom Rix <trix@xxxxxxxxxx> An allyesconfig has this linking error drivers/platform/x86/think-lmi.o: multiple definition of `fw_attr_class' drivers/platform/x86/dell/dell-wmi-sysman/sysman.o: first defined here fw_attr_class is only used locally, so change to static Signed-off-by: Tom Rix <trix@xxxxxxxxxx> --- drivers/platform/x86/think-lmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c index 782d8e3fe7a1e..c6413b906e4a3 100644 --- a/drivers/platform/x86/think-lmi.c +++ b/drivers/platform/x86/think-lmi.c @@ -134,7 +134,7 @@ static const char * const encoding_options[] = { [TLMI_ENCODING_SCANCODE] = "scancode", }; static struct think_lmi tlmi_priv; -struct class *fw_attr_class; +static struct class *fw_attr_class; /* ------ Utility functions ------------*/ /* Convert BIOS WMI error string to suitable error code */ -- 2.26.3