From: Tom Rix <trix@xxxxxxxxxx> An allyesconfig has this linking error drivers/platform/x86/think-lmi.o: multiple definition of `fw_attr_class' drivers/platform/x86/dell/dell-wmi-sysman/sysman.o: first defined here fw_attr_class is only used locally, so change to static Signed-off-by: Tom Rix <trix@xxxxxxxxxx> --- drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c index 1378c18786582..636bdfa83284d 100644 --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c @@ -25,7 +25,7 @@ struct wmi_sysman_priv wmi_priv = { /* reset bios to defaults */ static const char * const reset_types[] = {"builtinsafe", "lastknowngood", "factory", "custom"}; static int reset_option = -1; -struct class *fw_attr_class; +static struct class *fw_attr_class; /** -- 2.26.3