On 2021-06-09 11:19 a.m., Hans de Goede wrote:
> Hi,
>
> On 6/9/21 5:17 PM, Hans de Goede wrote:
>> tlmi_priv.pwd_admin->password is an array (not a pointer), so the correct
>> way to check for the password being set is to check for
>> tlmi_priv.pwd_admin->password[0] != 0.
>>
>> For the second check, replace the check with checking that auth_str is
>> set instead.
>>
>> Cc: Mark Pearson <markpearson@xxxxxxxxxx>
>> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>> Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx>
>> Addresses-Coverity-ID: 1505158 ("NO_EFFECT")
>> Fixes: a7314b3b1d8a ("platform/x86: think-lmi: Add WMI interface support on Lenovo platforms")
>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> I've added this series to my review-hans branch (soon to be pdx86/for-next) branch now.
>
> Regards,
>
> Hans
>
Thanks Hans - I was just about to start looking at these. You're fast :)
I think you've fixed everything I saw flagged - let me know if there is
anything else I should look at and might have missed.
Mark
