Hi, On 6/8/21 7:48 PM, Nathan Chancellor wrote: > On Mon, May 31, 2021 at 03:56:41PM +0200, Hans de Goede wrote: >> Hi, >> >> On 5/31/21 12:31 AM, Mark Pearson wrote: >>> This will be used by the Dell and Lenovo WMI management drivers to >>> prevent both drivers being active. >>> >>> Reported-by: kernel test robot <lkp@xxxxxxxxx> >>> Signed-off-by: Mark Pearson <markpearson@xxxxxxxxxx> >>> --- >>> Changes in v2: >>> - This is a new file requested as part of the review of the proposed >>> think_lmi.c driver. Labeling as V2 to keep series consistent >>> >>> Changes in v3: >>> - Set default in Kconfig, and removed help text >>> - Allow multiple modules to register with module. Change API names to >>> better reflect this. >>> >>> Changes in v4: >>> - version bump for consistency in series >>> >>> Changes in v5: >>> - Fix issue reported by kernel test robot. Add header file to includes >> >> Thanks Mark, >> >> Unfortunately you squashed the Kconfig and Makefile changes which I made >> to v4 when fixing it up during merging into 3/3 instead of having them in >> v5 of this patch. >> >> No worries, since this was the only problem which I could see I've fixed >> this up in my review-hans branch while merging v5 of this series there >> (replacing v4). >> >> I did notice a bit of dead code while reviewing the changes which you >> made to 3/3 in response to Andy's review. I'll send a follow-up patch >> fixing that. >> >> I'll leave this sit in my review-hans branch for a bit to give Andy >> a chance to give his Reviewed-by and then I'll push this to for-next. >> >> Regards, >> >> Hans > > It looks like this series causes allyesconfig to break on linux-next: > > https://github.com/ClangBuiltLinux/continuous-integration2/runs/2773158286?check_suite_focus=true > > $ make -skj"$(nproc)" allyesconfig all > ld: drivers/platform/x86/think-lmi.o:(.bss+0x0): multiple definition of `fw_attr_class'; drivers/platform/x86/dell/dell-wmi-sysman/sysman.o:(.bss+0x0): first defined here Thank you for reporting this. This is caused by both these files: drivers/platform/x86/dell/dell-wmi-sysman/sysman.c drivers/platform/x86/think-lmi.c having a global struct class *fw_attr_class variable, which should be static in both files. I'll send a patch fixing this (and merge the patch into the pdx86/for-next branch). Regards, Hans
