Hi, On 6/7/21 3:47 AM, yangerkun wrote: > drivers/platform/x86/intel_ips.c:832:6: warning: variable ‘ret’ set but > not used [-Wunused-but-set-variable] > 832 | u16 ret; > | ^~~ > > Fix it by mark ret as '__maybe_unused'. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: yangerkun <yangerkun@xxxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/intel_ips.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c > index bffe548187ee..4dfdbfca6841 100644 > --- a/drivers/platform/x86/intel_ips.c > +++ b/drivers/platform/x86/intel_ips.c > @@ -829,7 +829,7 @@ static u16 calc_avg_temp(struct ips_driver *ips, u16 *array) > > static u16 read_mgtv(struct ips_driver *ips) > { > - u16 ret; > + u16 __maybe_unused ret; > u64 slope, offset; > u64 val; > >
