Hi, On 1/26/21 11:00 PM, David E. Box wrote: > Hi Hans, > > Sorry for missing the discussion on this. Need to fix my mail > filtering. I just submitted patches that instead make INTEL_PMT_CLASS > non-user-selectable, leaving the other dependencies in place. Having > the class driver user-selectable was a mistake. > > I also did go ahead and add a dependancy on the MFD driver since all > current PMT features are only exposed through this driver. So users > will only see the following options: > > MFD_INTEL_PMT > INTEL_PMT_TELEMETRY (selects INTEL_PMT_CLASS) > INTEL_PMT_CRASHLOG (selects INTEL_PMT_CLASS) Ok, your version looks good, so I will merge it instead of my version. Regards, Hans > > David > > On Tue, 2021-01-26 at 21:20 +0100, Hans de Goede wrote: >> Make the PMT Kconfig options depend on INTEL_PMT_CLASS instead of >> selecting it. Select should only be used with hidden options and >> INTEL_PMT_CLASS is not hidden. >> >> This will stop Kconfig from asking if INTEL_PMT_TELEMETRY and >> INTEL_PMT_CRASHLOG should be enabled after the user says no >> to the INTEL_PMT_CLASS prompt. >> >> Reported-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> >> Cc: Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx> >> Cc: David E. Box <david.e.box@xxxxxxxxxxxxxxx> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> --- >> drivers/platform/x86/Kconfig | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/platform/x86/Kconfig >> b/drivers/platform/x86/Kconfig >> index 9a73e7baa344..d4f32fc0e40e 100644 >> --- a/drivers/platform/x86/Kconfig >> +++ b/drivers/platform/x86/Kconfig >> @@ -1383,7 +1383,7 @@ config INTEL_PMT_CLASS >> >> config INTEL_PMT_TELEMETRY >> tristate "Intel Platform Monitoring Technology (PMT) >> Telemetry driver" >> - select INTEL_PMT_CLASS >> + depends on INTEL_PMT_CLASS >> help >> The Intel Platform Monitory Technology (PMT) Telemetry >> driver provides >> access to hardware telemetry metrics on devices that >> support the >> @@ -1394,7 +1394,7 @@ config INTEL_PMT_TELEMETRY >> >> config INTEL_PMT_CRASHLOG >> tristate "Intel Platform Monitoring Technology (PMT) Crashlog >> driver" >> - select INTEL_PMT_CLASS >> + depends on INTEL_PMT_CLASS >> help >> The Intel Platform Monitoring Technology (PMT) crashlog >> driver provides >> access to hardware crashlog capabilities on devices that >> support the > >
