Hi, On 2/3/21 11:48 AM, Hans de Goede wrote: > Hi, > > On 1/26/21 3:00 PM, Andy Shevchenko wrote: >> Surround WMI drivers by 'if ACPI_WMI' instead of depending >> each of them separately. > > This does not cover all drivers which depend on ACPI_WMI; and in > for-next there is a new UV_SYSFS Kconfig symbol in the middle of > the block which you are surrounding with if ACPI_WMI .. endif > and that new Kconfig symbol does not depend on ACPI_WMI. > > Admittedly I should have payed more attention when the UV_SYSFS > symbol was merged, but atm there is no real ordering in the > Kconfig symbols. Ok, so I just checked the Makefile and noticed that there is an ordering there. But most people start with looking at Kconfig when adding a new driver and the ordering is very much not clear there. Also splitting the Intel bits in three groups does not necessariyl help IMHO. E.g CONFIG_INTEL_CHT_INT33FE is in the generic Intel block but it is definitely PMIC related. And the WMI drivers are grouped, except that some of them (Asus, Dell, EEEPC at least) are not in the group... So I still think just sorting the entire bups alphabetically is better. We can then also add a comment at the top to please keep things sorted alphabetically. Regards, Hans
