On 1/25/21 10:25 PM, Barnabás Pőcze wrote: > Hi > > > 2021. január 25., hétfő 9:55 keltezéssel, Ike Panhc írta: > >> On 1/14/21 2:22 AM, Barnabás Pőcze wrote: >>> Fix (almost all) checkpatch warnings. Reorder variable definitions from >>> longest to shortest. Add more whitespaces for better readability. Rename >>> variables named `ret` to `err` where appropriate. >>> >>> Signed-off-by: Barnabás Pőcze <pobrn@xxxxxxxxxxxxxx> >>> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> >>> >>> @@ -265,30 +280,40 @@ static int debugfs_status_show(struct seq_file *s, void *data) >>> >>> if (!read_ec_data(priv->adev->handle, VPCCMD_R_BL_MAX, &value)) >>> seq_printf(s, "Backlight max:\t%lu\n", value); >>> + >>> if (!read_ec_data(priv->adev->handle, VPCCMD_R_BL, &value)) >>> seq_printf(s, "Backlight now:\t%lu\n", value); >>> + >>> if (!read_ec_data(priv->adev->handle, VPCCMD_R_BL_POWER, &value)) >>> seq_printf(s, "BL power value:\t%s (%lu)\n", value ? "on" : "off", value); >>> + >>> seq_puts(s, "=====================\n"); >>> >>> if (!read_ec_data(priv->adev->handle, VPCCMD_R_RF, &value)) >>> seq_printf(s, "Radio status:\t%s (%lu)\n", value ? "on" : "off", value); >>> + >>> if (!read_ec_data(priv->adev->handle, VPCCMD_R_WIFI, &value)) >>> seq_printf(s, "Wifi status:\t%s (%lu)\n", value ? "on" : "off", value); >>> + >>> if (!read_ec_data(priv->adev->handle, VPCCMD_R_BT, &value)) >>> seq_printf(s, "BT status:\t%s (%lu)\n", value ? "on" : "off", value); >>> + >>> if (!read_ec_data(priv->adev->handle, VPCCMD_R_3G, &value)) >>> seq_printf(s, "3G status:\t%s (%lu)\n", value ? "on" : "off", value); >>> + >>> seq_puts(s, "=====================\n"); >>> >>> if (!read_ec_data(priv->adev->handle, VPCCMD_R_TOUCHPAD, &value)) >>> seq_printf(s, "Touchpad status:\t%s (%lu)\n", value ? "on" : "off", value); >>> + >>> if (!read_ec_data(priv->adev->handle, VPCCMD_R_CAMERA, &value)) >>> seq_printf(s, "Camera status:\t%s (%lu)\n", value ? "on" : "off", value); >>> + >>> seq_puts(s, "=====================\n"); >>> >>> if (!eval_gbmd(priv->adev->handle, &value)) >>> seq_printf(s, "GBMD: %#010lx\n", value); >>> + >>> if (!eval_hals(priv->adev->handle, &value)) >>> seq_printf(s, "HALS: %#010lx\n", value); >>> >> >> checkpatch.pl suggests empty lines? I think they are doing the same thing. It's better >> to put them tightly. >> >> -- >> Ike > > I added them at my own discretion, and I don't recall checkpatch suggesting > it, so if you want to, I can remove them, but I'd like to keep one empty > line before and after > > seq_puts(s, "=====================\n"); > > . > > What do you think? > > > Regards, > Barnabás Pőcze > That looks great. Many thanks. -- Ike
