On Sat, Jan 16, 2021 at 11:28 PM Barnabás Pőcze <pobrn@xxxxxxxxxxxxxx> wrote:
> 2021. január 16., szombat 21:42 keltezéssel, Andy Shevchenko írta:
> > On Sat, Jan 16, 2021 at 10:28 PM Barnabás Pőcze wrote:
...
> > It has no difference in this patch where to place a line which you have changed.
> >
> > + int val, err;
> > unsigned long int end_jiffies;
> >
> > is the same as
> >
> > unsigned long int end_jiffies;
> > + int val, err;
(1)
> > I don't understand what "few modifications" you mentioned above?
> > [...]
>
> In other commits there were instances where I could've made
> similar changes, but I chose not to, because I wanted to keep
> the "stylistic" and functional changes separate.
> For example, in patch 9:
>
> @@ -353,9 +353,11 @@ static ssize_t show_ideapad_cam(struct device *dev,
> {
> unsigned long result;
> struct ideapad_private *priv = dev_get_drvdata(dev);
> + int err;
(2)
> I did not change the order. Is that OK or do you think it'd be
> preferable to change the order here as well?
I see, The case (1) above is different to this. and actually in (2)
you do right.
And I agree that in latter case (2) the stylistic should be *a
separate* change, which is completely the right thing to do.
--
With Best Regards,
Andy Shevchenko
