Hi > On Wed, Jan 13, 2021 at 8:22 PM Barnabás Pőcze wrote: > > > > ACPI helpers returned -1 in case of failure. Convert these functions to > > return appropriate error codes, and convert their users to propagate > > these error codes accordingly. > > ... > > > - int val; > > + int val, err; > > unsigned long int end_jiffies; > > Perhaps in this and other similar cases switch to reversed xmas tree > order at the same time? > [...] Thanks for the review; I intentionally tried to make as few modifications as possible in order to achieve what I wanted. I deemed it better to place all "coding style"-related changes in their own patch (19). I would prefer to keep it this way. Do you have any objections? Thanks, Barnabás Pőcze