RE: [PATCH] x86/platform/uv: Fix an error code in uv_hubs_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Return -ENOMEM on allocation failure instead of returning success.
> 
> Fixes: 4fc2cf1f2daf ("x86/platform/uv: Add new uv_sysfs platform driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thank you for taking the time to find this.

Reviewed-by: Justin Ernst <justin.ernst@xxxxxxx> 
(With an acknowledgement of Boris's 's/success/random stack memory contents/' comment)

> ---
>  drivers/platform/x86/uv_sysfs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
> index 54c342579f1c..e17ce8c4cdad 100644
> --- a/drivers/platform/x86/uv_sysfs.c
> +++ b/drivers/platform/x86/uv_sysfs.c
> @@ -248,6 +248,7 @@ static int uv_hubs_init(void)
>  		uv_hubs[i] = kzalloc(sizeof(*uv_hubs[i]), GFP_KERNEL);
>  		if (!uv_hubs[i]) {
>  			i--;
> +			ret = -ENOMEM;
>  			goto err_hubs;
>  		}
> 
> --
> 2.29.2





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux