Hi, On 11/25/20 7:50 AM, Qinglang Miao wrote: > Fix to return the error code -ENODEV when fails to init wmi and > smm. > > Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-* modules together") > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Qinglang Miao <miaoqinglang@xxxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/dell-smbios-base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c > index 2e2cd5659..3a1dbf199 100644 > --- a/drivers/platform/x86/dell-smbios-base.c > +++ b/drivers/platform/x86/dell-smbios-base.c > @@ -594,6 +594,7 @@ static int __init dell_smbios_init(void) > if (wmi && smm) { > pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n", > wmi, smm); > + ret = -ENODEV; > goto fail_create_group; > } > >