Hi,
On 12/1/20 2:57 PM, Carlos Garnacho wrote:
> This 2-in-1 model (Product name: Switch SA5-271) features a SW_TABLET_MODE
> that works as it would be expected, both when detaching the keyboard and
> when folding it behind the tablet body.
>
> It used to work until the introduction of the allow list at commit
> 8169bd3e6e193 ("platform/x86: intel-vbtn: Switch to an allow-list for
> SW_TABLET_MODE reporting"). Add this model to it, so the Virtual Buttons
> device announces the EV_SW features again.
>
> Signed-off-by: Carlos Garnacho <carlosg@xxxxxxxxx>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/intel-vbtn.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index f5901b0b07cd..d8114983498b 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -206,6 +206,12 @@ static const struct dmi_system_id dmi_switches_allow_list[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "HP Stream x360 Convertible PC 11"),
> },
> },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Switch SA5-271"),
> + },
> + },
> {} /* Array terminator */
> };
>
>
