On Thu, 2020-09-17 at 15:24 +0200, Hans de Goede wrote: > Hi, > > On 9/17/20 3:02 PM, Barnabás Pőcze wrote: > > Hi > > > > > > 2020. szeptember 17., csütörtök 13:22 keltezéssel, Hans de Goede > > írta: > > > > > [...] > > > I guess we should also add an optional lap_mode sysfs attribute > > > to the class-device, to have all the info for the Thinkpads in > > > one place. > > > [...] > > > > > > Excuse my ignorance, but why does "lap_mode" need to be here? > > I understand the implications of it regarding performance, but > > I think it would be more sense to export it via the hwmon (or > > something similar) subsystem? What am I missing? > > Well hwmon has very clearly defined sensor types, like voltage, > fan-speed and temperature. lap_mode does not match any of them. > > Also registering another-type class device just for the lap_mode > boolean seems overkill, esp. since lap_mode is inherently coupled > to the performance-profile stuff. There's proximity sensors in the IIO subsystem which this could use (I guess that was what was planned to be used, as that's how I got involved in power-profiles-daemon).
