Hi,
On 8/31/20 2:02 PM, Marius Iacob wrote:
On 20-08-31 12:18:27, Hans de Goede wrote:
<snip>
Unfortunately the PNP check is 2 layers deeper from module_init and it's expected to return 0 for success for the rest of the init procedure to continue (so that it's not that straightforward). The module seems to be built with a full init procedure on load in mind. I've looked at the code for quite a bit and it seems that it's a bit of patch to write, and most of the places the i8042 code is used (in other modules) expects the module to be not just loaded but fully initialized. So this should be a consideration also.
Please give the attached patch a try, I believe that this should fix the i8042 issue.
Once you have let me know that this works I'll replace the:
Reported-by: Marius Iacob <themariusus@xxxxxxxxx>
By:
Reported-and-tested-by: Marius Iacob <themariusus@xxxxxxxxx>
And submit the patch upstream. Note the input subsys
maintainers seems to be a bit slow to respond lately,
so I'm not sure how fast we can get this reviewed / merged.
Anyways first lets test it and see if it helps :)
The patch works as intended. I also tried it on a system that has PS/2 controller and the module works as intended on that system too.
Great, thank you for testing. I've submitted the patch upstream.
Regards,
Hans
