Am Freitag, den 10.07.2020, 23:46 +0300 schrieb Andy Shevchenko:
> On Fri, Jul 10, 2020 at 9:24 PM Armas Spann <
> zappel@xxxxxxxxxxxxx
> > wrote:
> > Am Donnerstag, den 09.07.2020, 22:19 +0300 schrieb Andy Shevchenko:
> > > On Thu, Jul 9, 2020 at 10:18 PM Andy Shevchenko
> > > <
> > > andy.shevchenko@xxxxxxxxx
> > >
> > > > wrote:
> > > > On Wed, Jun 17, 2020 at 3:02 PM Armas Spann <
> > > > zappel@xxxxxxxxxxxxx
> > > >
> > > > > wrote:
> > > > > Support for the currently unsupported ASUS G14 Notebooks (GA401I
> > > > > series)
> > > > > to the asus(-nb)-wmi.c sources.
> > > > > First change is the on the input buffer, the new devices are sending 5
> > > > > DWORD instead of 3 as it was definded before. (might be already
> > > > > submitted
> > > > > upstream)
> > > > >
> > > > > The second part of the patch adds the correct device dmi
> > > > > identificator.
> > > >
> > > > I can't take patch w/o Signed-off-by. See [1] for the details.
> > > >
> > > > On top of that it doesn't apply. And it clashes with already applied
> > > > 7b91f1565fbf ("platform/x86: asus_wmi: Reserve more space for struct
> > > > bias_args")
> > >
> > > [1]:
> > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> > >
> > >
> > >
> > >
> > >
> >
> > Many thanks for your feedback.
> > I must excuse myself for not beeing guideline conform.
> >
> > Now, I removed the already fixed input_buffer and added the ASUS Zephyrus
> > ROG
> > G502I Series as well.
> >
> > Corrected patch:
>
> Good. Now you need to do it so:
> - it has proper and clear commit message (and being committed locally)
> - you commit change with `git commit -a -s` which adds correctly the
> Signed-off-by tag
> - with help of `git format-patch -v<N> -1 HEAD~0` you create a file
> with patch, where `<N>` corresponds to the version of it, now I guess
> it's something like 3 or 4
> - you open that file in editor and add a changelog after cutter '---'
> line, save it
> - with help of `git send-email 0001-*` you can send that patch to the
> mailing lists (don't forget to Cc maintainers as well)
>
>
Many thanks for this brief explanation. I hope that I did it now correct, so I'm
not wasting more of your time. (the email was just sent via git)
Best Regards,Armas Spann
