Am Donnerstag, den 09.07.2020, 22:19 +0300 schrieb Andy Shevchenko:
> On Thu, Jul 9, 2020 at 10:18 PM Andy Shevchenko
> <
> andy.shevchenko@xxxxxxxxx
> > wrote:
> > On Wed, Jun 17, 2020 at 3:02 PM Armas Spann <
> > zappel@xxxxxxxxxxxxx
> > > wrote:
> > > Support for the currently unsupported ASUS G14 Notebooks (GA401I series)
> > > to the asus(-nb)-wmi.c sources.
> > > First change is the on the input buffer, the new devices are sending 5
> > > DWORD instead of 3 as it was definded before. (might be already submitted
> > > upstream)
> > >
> > > The second part of the patch adds the correct device dmi identificator.
> >
> > I can't take patch w/o Signed-off-by. See [1] for the details.
> >
> > On top of that it doesn't apply. And it clashes with already applied
> > 7b91f1565fbf ("platform/x86: asus_wmi: Reserve more space for struct
> > bias_args")
>
> [1]:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>
>
>
>
Many thanks for your feedback.
I must excuse myself for not beeing guideline conform.
Now, I removed the already fixed input_buffer and added the ASUS Zephyrus ROG
G502I Series as well.
Corrected patch:
--- linux/drivers/platform/x86/asus-nb-wmi.c.orig 2020-07-10
19:31:02.288784987 +0200
+++ linux/drivers/platform/x86/asus-nb-wmi.c 2020-07-10 19:59:04.515645657
+0200
@@ -110,6 +110,16 @@ static struct quirk_entry quirk_asus_for
.wmi_force_als_set = true,
};
+static struct quirk_entry quirk_asus_ga401i = {
+ .wmi_backlight_power = true,
+ .wmi_backlight_set_devstate = true,
+};
+
+static struct quirk_entry quirk_asus_ga502i = {
+ .wmi_backlight_power = true,
+ .wmi_backlight_set_devstate = true,
+};
+
static int dmi_matched(const struct dmi_system_id *dmi)
{
pr_info("Identified laptop model '%s'\n", dmi->ident);
@@ -411,6 +421,78 @@ static const struct dmi_system_id asus_q
},
.driver_data = &quirk_asus_forceals,
},
+ {
+ .callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. GA401IH",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "GA401IH"),
+ },
+ .driver_data = &quirk_asus_ga401i,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. GA401II",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "GA401II"),
+ },
+ .driver_data = &quirk_asus_ga401i,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. GA401IU",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "GA401IU"),
+ },
+ .driver_data = &quirk_asus_ga401i,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. GA401IV",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "GA401IV"),
+ },
+ .driver_data = &quirk_asus_ga401i,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. GA401IVC",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "GA401IVC"),
+ },
+ .driver_data = &quirk_asus_ga401i,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. GA502II",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "GA502II"),
+ },
+ .driver_data = &quirk_asus_ga502i,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. GA502IU",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "GA502IU"),
+ },
+ .driver_data = &quirk_asus_ga502i,
+ },
+ {
+ .callback = dmi_matched,
+ .ident = "ASUSTeK COMPUTER INC. GA502IV",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "GA502IV"),
+ },
+ .driver_data = &quirk_asus_ga502i,
+ },
{},
};
--
Signed-off-by: Armas Spann <zappel@xxxxxxxxxxxxx>
