On Mon, May 11, 2020 at 09:08:31PM +0100, Richard Hughes wrote: > > For the security stuff you are adding, do you need to look at the PCI > > device registers as well? > > No, just the config space. I guess at some point I might want to put > some of the chipsec vulnerability checks into the module, although I'm > not happy adding anything remotely dangerous. I mean for the SPI-NOR controller PCI device registers (not the LPC PCI device, sorry about not being clear), like config space. Typically it is PCI device 1f.5 and in that case you can't use the LPC driver because it should not touch other devices than what it is bound to (OK, there are exceptions but still). If that's the case then I guess this should go to intel-spi-pci/platform drivers after all. I think one option is that we add Kconfig option that makes the driver load but only provide the security bits without actually calling intel_spi_probe().
