On Fri, May 08, 2020 at 05:15:07PM +0100, Richard Hughes wrote: > On Fri, 8 May 2020 at 09:20, Mika Westerberg > <mika.westerberg@xxxxxxxxxxxxxxx> wrote: > > Thanks for the information. I actually prefer that this would be in a > > separate driver because I do not want distros to enable intel-spi just > > for this. It is really only meant for special setups where firmware > > upgrade/access flow has been thoroughly tested. > > Do you think the driver should be part of mtd (e.g. something like > drivers/mtd/spi-nor/controllers/intel-spi-pci-lpc.c) or be something > like I proposed in drivers/platform/x86? Ideas very welcome, thanks. I think you may want to look at drivers/mfd/lpc_ich.c and see if some of this can be placed there. It is the "LPC" driver that binds to the LPC/eSPI PCI device so it already has at least some of these PCI IDs.