On Wed, Sep 25, 2019 at 06:02:22PM +0300, Andy Shevchenko wrote:
> On Sat, Sep 21, 2019 at 9:31 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> >
> > Hi,
> >
> > On 21-09-2019 00:33, Yauhen Kharuzhy wrote:
> > > Existing intel_cht_int33fe ACPI pseudo-device driver assumes that
> > > hardware has Type-C connector and register related devices described as
> > > I2C connections in the _CRS resource.
> > >
> > > There is at least one hardware (Lenovo Yoga Book YB1-91L/F) with Micro-B
> > > USB connector exists. It has INT33FE device in the DSDT table but
> > > there are only two I2C connection described: PMIC and BQ27452 battery
> > > fuel gauge.
> > >
> > > Splitting existing INT33FE driver allow to maintain code for USB Micro-B
> > > (or AB) connector variant separately and make it simpler.
> > >
> > > Split driver to intel_cht_int33fe_common.c and
> > > intel_cht_int33fe_{microb,typec}.c. Compile all this sources to one .ko
> > > module to make user experience easier.
> > >
> > > Signed-off-by: Yauhen Kharuzhy <jekhor@xxxxxxxxx>
> >
> > This version still works for me on my typec device:
> >
> > Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> >
> > The code also looks good to me:
> >
> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> >
>
> By some reason it doesn't apply.
I have checked, and have no issues when applying this patch to the current
torvalds/master and linux-next/master branches (351c8a09b00b and 9e88347dedd8
commit IDs).
--
Yauhen Kharuzhy
