Hi,
On 8/23/19 4:47 PM, Andy Shevchenko wrote:
On Fri, Aug 23, 2019 at 5:22 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
Hi,
On 8/20/19 10:41 AM, Linus Walleij wrote:
On Sun, Aug 18, 2019 at 6:19 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
Note that the gpio_chip structure already has a init_valid_mask
callback which runs after gpiochip_irqchip_init_valid_mask wich
allocs gpio_chip.irq.valid_mask, so we might use that, but:
That is intended to setup the valid_mask for the pins, not for
the IRQs, which would mean we are abusing it a bit and it runs
after gpiochip_add_irqchip(), which might be too late I guess.
Yeah there are two of them which is quite confusing. I am trying
to clean up the mess step by step. The initialization of the valid_mask
for the pins itself (which is BTW also there for ACPI mainly) is
rewritten, I just merged these:
https://lore.kernel.org/linux-gpio/20190819084904.30027-1-linus.walleij@xxxxxxxxxx/
https://lore.kernel.org/linux-gpio/20190819091140.622-1-linus.walleij@xxxxxxxxxx/
https://lore.kernel.org/linux-gpio/20190819093058.10863-1-linus.walleij@xxxxxxxxxx/
This makes things a bit clearer, now I "just" need to do the same
for the gpio_irq_chip.
So it looks like we need a gpio_chip.irq.init_valid_mask callback
to fix this ordering problem and until this is fixed we should revert
2e65e0fad935f578e998656d3e7be5a26e072b0e.
Do you think this patch, created in response to an ACPI bug in
similar vein for PL061 fixes the ordering problem:
https://lore.kernel.org/linux-gpio/20190820080527.11796-1-linus.walleij@xxxxxxxxxx/
Just applying it on top and see if the interrups storm is fixed
would be super...
I can confirm that that patch, fixed the issue I was seeing with
your "platform: x86: vgpio: Pass irqchip when adding gpiochip" patch
with both patches combined things work fine.
Thank you very much, Hans, for testing and, Linus, for fixing.
Linus, I'll wait your patch appears in next rc and then I will reapply
your clean ups.
Note Linus' reordering patch only fixes the issue with ACPI event handlers
no longer registering. The ordering issue in the BYT pinctrl code where
it tries to write chip.irq.valid_mask[x] while valid_mask is a NULL
pointer is NOT fixed by this.
Regards,
Hans
drivers/platform/x86/intel_int0002_vgpio.c
