Re: [PATCH v2] platform/x86: asus-wmi: Support setting a maximum charging percentage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12.08.2019 14.57, Kristian Klausen wrote:
https://www.asus.com/us/support/FAQ/1032726/ doesn't really help us
here, looks like it was not written by a native English speaker.

maximum_charging_percentage is a bit long, but how about
max_battery_charge or max_charge ?
Maybe battery_max_charge to follow the same pattern as the LG/Samsumg modules (battery_care_limit/battery_life_extender).

What do you think?
I've done some more research. We should probably use the new battery hooking API[1], in a way similar to the the thinkpad_acpi module[2]. Naming wise we should use the recently added official charge control knobs[3].


[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa93854f7a7ed63d054405bf3779247d5300edd3 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2801b9683f740012863f7f0b1f0bc770c417fe72 [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=813cab8f3994250e136819ae48fbd1c95d980466



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux