On 12.08.2019 09.23, Daniel Drake wrote:
On Fri, Aug 9, 2019 at 3:56 AM Kristian Klausen <kristian@xxxxxxxxxx> wrote:
The sysfs knob is still called "charge_threshold", as
maximum_charging_percentage seems a bit long.
I did look on some of the other platform modules, the LG module
use battery_care_limit and the Samsung module use
battery_life_extender.
Maybe it's just me, but I personally find the "threshold" part of this
to be a little unclear.
In other contexts a threshold is where something starts to happen,
rather than a stop point, and this had me confused at initial glance
of your first mail.
Hmm, yes it is confusing.
https://www.asus.com/us/support/FAQ/1032726/ doesn't really help us
here, looks like it was not written by a native English speaker.
maximum_charging_percentage is a bit long, but how about
max_battery_charge or max_charge ?
Maybe battery_max_charge to follow the same pattern as the LG/Samsumg
modules (battery_care_limit/battery_life_extender).
What do you think?
