On 08.08.2019 10.13, Daniel Drake wrote:
On Tue, Aug 6, 2019 at 3:23 AM Kristian Klausen <kristian@xxxxxxxxxx> wrote:
Most newer ASUS laptops supports limiting the battery charge level, which
help prolonging the battery life.
Tested on a Zenbook UX430UNR.
Signed-off-by: Kristian Klausen <kristian@xxxxxxxxxx>
---
I'm not sure what to call it, is charge threshold good enough or do you
have any better ideas?
The spec calls it "Maximum Charging Percentage". I think something
along those lines would be clearer.
I just sent a V2 patch.
I'm using "maximum charging percentage" in the documentation/commit
message, but the knob is still named "charge_threshold".
It would be good to have a one line explanatory comment against where
you introduce the variable, so that it's clear from glancing at the
code (not just the commit message) what this functionality actually
is.documentation
Ack
Also you need a Documentation/ entry for this new file where you can
describe it a little more verbosely.
Ack
The 0x00120057 device is officially called "Relative state of charge",
not sure if you want to somehow follow a similar naming scheme there,
I don't have a real preference.
The same name is used in ASUS online documentation. I change it.
https://www.asus.com/us/support/FAQ/1032726/
The current name also seems to lack DEVID.
/* Misc */
#define ASUS_WMI_DEVID_CAMERA 0x00060013
+#define ASUS_WMI_CHARGE_THRESHOLD 0x00120057
Please keep the devices ordered numerically by their ID
Ack
Kristian
