On Mon, Jul 1, 2019 at 10:58 AM Jean Delvare <jdelvare@xxxxxxx> wrote:
> On Sat, 29 Jun 2019 14:13:02 +0300, Andy Shevchenko wrote:
> > On Sat, Jun 29, 2019 at 12:41 PM Jean Delvare <jdelvare@xxxxxxx> wrote:
> > >
> > > Only one MODULE_SOFTDEP statement is allowed per module. Multiple
> > > dependencies must be expressed in a single statement.
> >
> > Some module init utils even do not support softdep.
>
> And?
And either change will not have an effect on those environments.
> > Nevertheless, the message is somewhat misleading. It's not "only one
> > allowed" — this is not true, it's "only first will be served".
> > This is how I read kmod sources.
>
> What practical difference does it make?
The precision in the description of the root cause. Misleading
messages may give a wrong picture on what's going on.
> > And perhaps better to fix them?
>
> It's not considered a bug, as it is already possible to have multiple
> dependencies listed, you only have to put them in the same statement.
> There are several other MODULE_* macros which also can be used only
> once per module (MODULE_LICENSE, MODULE_DESCRIPTION) so I see nothing
> fundamentally wrong with MODULE_SOFTDEP following the same model. The
> example provided clearly illustrates how multiple dependencies should
> be declared. One possible improvement would be to add a comment
> explicitly stating that this macro can only be used once per module.
>
> > At least I would rather support somelike
> > MODULE_SOFTDEP("pre: ...");
> > MODULE_SOFTDEP("post: ...");
>
> Feel free to implement this on your copious spare time if you think
> there is any actual value in this change. Personally I'm not sure and I
> just want to get the (driver) bug fixed. Fixing the driver is more
> simple and easier to backport if needed.
Yes, I agree, and your code looks good to me. Thank you for doing this.
I would prefer to see a clear commit message.
--
With Best Regards,
Andy Shevchenko
