On Mon, Jul 15, 2019 at 9:41 AM Daniel Drake <drake@xxxxxxxxxxxx> wrote: > > The Asus WMI spec indicates that the function being controlled here > is called "Fan Boost Mode". The spec uses the term "fan mode" is used to > refer to other things, including functionality expected to appear on > future products. > > Rename "fan mode" to "fan boost mode" to improve consistency with the > spec and to avoid a future naming conflict. > > There is no interface breakage here since this has yet to be included > in an official kernel release. I also updated the kernel version listed > under ABI accordingly. I would like to see if you have a consensus on this with Yurii. And by some reason I didn't hear Corentin for some time. > Please consider for Linux-5.3, otherwise we'd have an official released > kernel using the "fan_mode" name which would be more controversial to > change later. I am wondering why no one commented on this before... > -What: /sys/devices/platform/<platform>/fan_mode > +What: /sys/devices/platform/<platform>/fan_boost_mode > Date: Apr 2019 > -KernelVersion: 5.2 > +KernelVersion: 5.3 Probably date should be changed as well. -- With Best Regards, Andy Shevchenko
