Re: [PATCH 3/4] Platform: OLPC: Require CONFIG_POWER_SUPPLY for XO-1.75 EC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/29/19 1:34 AM, Lubomir Rintel wrote:
>   ERROR: "power_supply_put" [drivers/platform/olpc/olpc-xo175-ec.ko] undefined!
>   ERROR: "power_supply_changed" [drivers/platform/olpc/olpc-xo175-ec.ko] undefined!
>   ERROR: "power_supply_get_by_name" [drivers/platform/olpc/olpc-xo175-ec.ko] undefined!
> 
> Adding the dependency seems like a more reasonable thing compared to
> ifdef-ing the bits, as if one has an XO-1.75 they almost certainly want
> a baterry and AC adapter support.
> 
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
>  drivers/platform/olpc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/olpc/Kconfig b/drivers/platform/olpc/Kconfig
> index 1fa676c5e7fa..6f35c01254e5 100644
> --- a/drivers/platform/olpc/Kconfig
> +++ b/drivers/platform/olpc/Kconfig
> @@ -7,6 +7,7 @@ config OLPC_XO175_EC
>  	depends on ARCH_MMP || COMPILE_TEST
>  	depends on SPI_SLAVE
>  	depends on INPUT
> +	depends on POWER_SUPPLY
>  	select OLPC_EC
>  	help
>  	  Include support for the OLPC XO Embedded Controller (EC). The EC
> 


-- 
~Randy



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux