On 5/29/19 1:34 AM, Lubomir Rintel wrote: > Randy Dunlap says: > > drivers/platform/olpc/Kconfig needs to use "menuconfig" like all of the > other Kconfig files in drivers/platform/ so that its menu is listed in > the correct place in *config interfaces. > > Otherwise he's sad. > > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Thanks. > --- > drivers/platform/olpc/Kconfig | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/olpc/Kconfig b/drivers/platform/olpc/Kconfig > index 6f35c01254e5..919b489e24e8 100644 > --- a/drivers/platform/olpc/Kconfig > +++ b/drivers/platform/olpc/Kconfig > @@ -2,9 +2,19 @@ config OLPC_EC > select REGULATOR > bool > > +menuconfig OLPC_XO175 > + bool "Platform support for OLPC XO 1.75 hardware" > + depends on ARCH_MMP || COMPILE_TEST > + help > + Say Y here to get to see options for the ARM-based OLPC platform. > + This option alone does not add any kernel code. > + > + Unless you have an OLPC XO laptop, you will want to say N. > + > +if OLPC_XO175 > + > config OLPC_XO175_EC > tristate "OLPC XO 1.75 Embedded Controller" > - depends on ARCH_MMP || COMPILE_TEST > depends on SPI_SLAVE > depends on INPUT > depends on POWER_SUPPLY > @@ -15,3 +25,5 @@ config OLPC_XO175_EC > button, restart, shutdown and battery charging status. > > Unless you have an OLPC XO laptop, you will want to say N. > + > +endif # OLPC_XO175 > -- ~Randy