On Mon, Apr 8, 2019 at 9:58 PM Rajat Jain <rajatja@xxxxxxxxxx> wrote: > On Mon, Apr 8, 2019 at 11:41 AM Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: > > On Mon, Apr 8, 2019 at 9:36 PM Rajat Jain <rajatja@xxxxxxxxxx> wrote: > > Instead of adding module parameter and doing these prints, perhaps > > introduce another debugfs node. > > Uh, I actually did wanted to print them at the resume time in kernel > logs, because I think this is something kernel developers would be > responsible for debugging and thus would be great to have this > included within the kernel logs. User space tools may differ on > different distros and may or may not be looking for S0ix failures, and > particularly may not dump this new debugfs attribute. > > The other thing is that seemingly this could also help in situations > where debugfs is not configured? The keywords above "developers", "debugging", so, the concept of this driver is almost all about debugging, debugfs is not for users or esp. user space tools. So, I don't see any issue here with creating another node and use it for *debugging* whenever it's needed. -- With Best Regards, Andy Shevchenko
