On 2/24/19 3:36 AM, Vadim Pasternak wrote:
-----Original Message-----
From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck
Sent: Saturday, February 23, 2019 7:13 PM
To: Michael Shych <michaelsh@xxxxxxxxxxxx>; wim@xxxxxxxxxxxxxxxxxx;
andy@xxxxxxxxxxxxx; dvhart@xxxxxxxxxxxxx
Cc: linux-watchdog@xxxxxxxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx;
Vadim Pasternak <vadimp@xxxxxxxxxxxx>
Subject: Re: [PATCH v4 2/3] watchdog: mlx-wdt: introduce a watchdog driver for
Mellanox systems.
On 2/20/19 1:34 AM, michaelsh@xxxxxxxxxxxx wrote:
From: Michael Shych <michaelsh@xxxxxxxxxxxx>
Introduce watchdog driver for a various range of Mellanox Ethernet and
Infiniband switch systems.
Watchdog driver for Mellanox watchdog devices, implemented in
programmable logic device.
Main and auxiliary watchdog devices can exist on the same system.
There are several actions that can be defined in the watchdog:
system reset, start fans on full speed and increase a counter.
The last 2 actions are performed without a system reset.
Actions without reset are provided for auxiliary watchdog devices,
which is optional.
Access to HW registers is performed through generic regmap interface.
There are 2 types of HW watchdog implementations.
Type 1: actual HW timeout can be defined as power of 2 msec.
e.g. timeout 20 sec will be rounded up to 32768 msec.; maximum timeout
period is 32 sec (32768 msec.); get time-left isn't supported Type 2:
actual HW timeout is defined in sec. and it's the same as user-defined
timeout; maximum timeout is 255 sec; get time-left is supported;
Watchdog driver is probed from the common mlx_platform driver.
Signed-off-by: Michael Shych <michaelsh@xxxxxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Hi Guenter,
Thank you very much for your reviews.
How we should proceed for this patchset?
Who should take it to the next, watchdog or platform mainatainer?
Good question. For now I added it to my watchdog-next branch. But then strictly
speaking (and as far as I know) we don't have an Ack from the platform maintainer,
so maybe I should not have done that. Maybe we should wait for the platform part
to be merged by the platform maintainer. Thoughts, anyone ?
Guenter
