On Fri, Feb 15, 2019 at 7:16 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Fri, Feb 15, 2019 at 12:05 AM Enrico Weigelt, metux IT consult > Linus, this one looks good enough, though some style minors can be addressed: > - redundant parens (and actually I prefer to see x = readl(); x |= > ...; writel(); in three lines) > - useless blank lines > - style of parameters where one per line (it's not needed in this drivers) > > In any case, FWIW, > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> OK Enrico can you include Andy's Review tag when you respin, fix the spinlock issue I pointed out and send out as v4 and I'll apply it. Yours, Linus Walleij
