On Fri, Feb 15, 2019 at 12:05 AM Enrico Weigelt, metux IT consult <info@xxxxxxxxx> wrote: > > Hi folks, > > Thanks for an update. Linus, this one looks good enough, though some style minors can be addressed: - redundant parens (and actually I prefer to see x = readl(); x |= ...; writel(); in three lines) - useless blank lines - style of parameters where one per line (it's not needed in this drivers) In any case, FWIW, Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > this is version 3 of my APUv2/APUv3 series. > > change in V3: > > * gpio driver > * drop unncessary gpio id checks > * cleanup amd_fch_gpio_set() > * move iores outside probe() > * shorter NULL checks and correct error in probe() > * apu board driver > * drop unneeded init.h > * drop unnecessary comments > * clean up logging > * dont need to depend on KEYBOARD_GPIO > > > --mtx -- With Best Regards, Andy Shevchenko
