On Sun, Dec 02, 2018 at 02:36:24PM +0100, Hans de Goede wrote: > On 29-11-18 18:44, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > If the ISP is exposed as a PCI device VLV machines need the > > same treatment as CHV machines to power gate the ISP. Otherwise > > s0ix will not work. > Thank you for the patches, both look good to me: > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > I've added both patches and the "drm/i915: Assert that VED > and ISP are power gated" patch to me personal tree, which I > regularly test on various BYT/CHT devices. If I notice > anything wrt these patches I will let you know. I have pushed them to my review and testing queue, thanks! P.S. We have some time to hear from Hans if something wrong with them. -- With Best Regards, Andy Shevchenko