[...] > > > For example, index printing. Please, remove it. I completely > > > forgot > > > about userspace powerful tools. At least two very old and nice > > > can > > > enumerate lines for you. > > > Obviously the index printing is redundant. > > > > Index printing is required here (for LTR Show and LTR Ignore) > > because it > > paves an obvious and easy way for the users of this driver to know > > the > > IP number to be used for LTR ignore. This was specifically > > requested by > > some customer and Srinivas asked me to implement this so adding him > > for > > his inputs. > > So, why it should be in kernel? When user prints this, they usually > call `cat /.../file`, right? > Is it too hard to call `cat -n /.../file` instead? The benefit of > such > approach is that it's independent on the file we are printing. > > (Note, `grep -n <PATTERN> /.../file` does the same`) > > For more variants > https://stackoverflow.com/questions/8206370/add-numbers-to-the-beginning-of-every-line-in-a-file > We get copy/paste data from some serial terminals from systems which don't have traditional linux shell or busy box. Not sure if they can do cat "-n" option or have this command at all. So line number helps. They can't even store output as as file as this is RO file system. But I am not as sticky on this. Thanks, Srinivas
